[SLING-9620] ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Resource Resolver 1.6.16
• Fix Version/s: Resource Resolver 1.7.0
• Component/s: ResourceResolver
• Assignee: Robert Munteanu
• Reporter: Angela Schreiber
• Created: 30/Jul/20 14:21
• Updated: 28/Sep/21 19:53
• Resolved: 18/Aug/20 14:38

Description

while investigating an issue involving sling:alias, i ended up manually adding the property using JCR API calls. this involved first adding the sling:ResourceAlias and i noticed that sling:alias can be both single or multi-valued according to the node type definition:

/ Mixin node type to enable setting an alias on a resource
[sling:ResourceAlias]
    mixin
  
    // alias name(s) for the node (single or multi-value)
  - sling:alias (string)
  - sling:alias (string) multiple

when setting multiple values for the sling:alias property, i found that ResourceMapper.getAllMappings only returns the first alias.

looking at the implementation in ResourceMapperImpl.loadAliasIfApplicable, it seems that line 216 (String alias = ResourceResolverControl.getProperty(current, ResourceResolverImpl.PROP_ALIAS);), is the culprit as call will in any case just return a single string (it calls getProperty(res, propName, String.class)).

as a consequence consumers of the ResourceMapper.getAllMappings method will not get a complete list of all aliases available.

Issue Links

• is related to: SLING-9622 Avoid registration of auth requirements for aliases and vanity paths
• relates to: SLING-10844 ResourceMapper.getMapping() returns null for empty path and unreadable root