[SLING-9381] Upgrade RRD4J to version 3.6 (Java 11 compatible)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Commons Metrics RRD4J 1.0.2
• Fix Version/s: Commons Metrics RRD4J 1.0.4
• Component/s: Commons
• Assignee: Robert Munteanu
• Reporter: Harsh Mehta
• Created: 17/Apr/20 12:01
• Updated: 17/Nov/21 16:59
• Resolved: 17/Apr/20 12:32

Description

RRD4J version 3.1 is using a JDK internal API that has been removed from Java 9 onwards.
https://github.com/rrd4j/rrd4j/issues/72

Also, Executor is not shutdown due to the above exception while closing database connection and this leads to a high number of exception in logs when the bundle is stopped

02.03.2020 23:17:17.169 *ERROR* [metrics-RRD4JReporter-1-thread-1] com.codahale.metrics.ScheduledReporter Exception thrown from RRD4JReporter#report. Exception was suppressed.
java.lang.IllegalStateException: RRD already closed, cannot store this sample
 at org.rrd4j.core.RrdDb.store(RrdDb.java:512) [org.apache.sling.commons.metrics-rrd4j:1.0.2]
 at org.rrd4j.core.Sample.update(Sample.java:194) [org.apache.sling.commons.metrics-rrd4j:1.0.2]
 at org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter.report(RRD4JReporter.java:260) [org.apache.sling.commons.metrics-rrd4j:1.0.2]
 at com.codahale.metrics.ScheduledReporter.report(ScheduledReporter.java:235) [com.adobe.granite.dropwizard.metrics:3.2.4]
 at com.codahale.metrics.ScheduledReporter$1.run(ScheduledReporter.java:174) [com.adobe.granite.dropwizard.metrics:3.2.4]
 at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
 at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
 at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
 at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
 at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
 at java.base/java.lang.Thread.run(Thread.java:834)

02.03.2020 23:17:17.169 *ERROR* [metrics-RRD4JReporter-1-thread-1] com.codahale.metrics.ScheduledReporter Exception thrown from RRD4JReporter#report. Exception was suppressed.

java.lang.IllegalStateException: RRD already closed, cannot store this sample

at org.rrd4j.core.RrdDb.store(RrdDb.java:512) [org.apache.sling.commons.metrics-rrd4j:1.0.2]

at org.rrd4j.core.Sample.update(Sample.java:194) [org.apache.sling.commons.metrics-rrd4j:1.0.2]

at org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter.report(RRD4JReporter.java:260) [org.apache.sling.commons.metrics-rrd4j:1.0.2]

at com.codahale.metrics.ScheduledReporter.report(ScheduledReporter.java:235) [com.adobe.granite.dropwizard.metrics:3.2.4]

at com.codahale.metrics.ScheduledReporter$1.run(ScheduledReporter.java:174) [com.adobe.granite.dropwizard.metrics:3.2.4]

at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)

at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)

at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)

at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)

at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)

at java.base/java.lang.Thread.run(Thread.java:834)

Issue Links

• is duplicated by: SLING-9192 Update RRD4j to (at least) version 3.5
• links to: GitHub Pull Request #2