Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-9247

Improve Performance Of Testing Ignored GET Parameters

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Dynamic Include 3.1.6
    • Fix Version/s: Dynamic Include 3.2.0
    • Component/s: Extensions
    • Labels:
      None

      Description

      This is a follow-up on SLING-9045

      org.apache.sling.dynamicinclude.Configuration loads the list of ignored GET parameters into a java.util.List which is further checked from IncludeTagFilter via List#contains

      Calling List#contains in a loop is kind of a smell. I believe java.util.Set will be a more appropriate container with fixed O(1) cost of contains().

       

        Attachments

          Activity

            People

            • Assignee:
              rombert Robert Munteanu
              Reporter:
              yegor.kozlov Yegor Kozlov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m