Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-913

Add a cache for pre-compiled scripts

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      The Java Scripting API provides support for scripting langugages which may precompile script source and reuse the precompiled scripts:

      javax.script.Compilable: May be implemented by a ScriptEngine if precompilation is
      supported
      javax.script.CompiledScript: Result of calling the Compilable.compile method.

      The CompiledScript can be called to repeatedly execute the script without the need for recompilation and thus for improved performance.

      The Sling Core Scripting support should make use of this functionality by maintaining a cache compiled scripts with the following properties

      • indexed by script path
      • size limited (using LinkedHashMap overwriting the removeEldestEntry method)
      • entries are weak or soft references ot cache entries

      A cache entry consists of the following information:

      • The CompiledScript instance
      • The time of last compilation. this is compared to the last modification time of the script to decide on whether to recompile

      We might probaly also try to add a reference to the script engine implementation bundle to only use the cache entry if the bundle has not been stopped since adding the cache entry

      Executing the script would then consist of the following steps:

      1 Check the cache of precompiled scripts. if an entry exists and can be used, use it
      2. if the ScriptEngine is Compilable:
      2a. Compile the script and add it to the cache and use it
      2b. Otherwise have the script engine execute the script

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            radu Radu Cotescu
            fmeschbe Felix Meschberger
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment