[SLING-9119] Sling Mock 2.4.0 breaks tests that invoke myTestServlet.service(..)

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Testing Sling Mock 2.4.0
• Component/s: Tooling
• Assignee: Unassigned
• Reporter: David Gonzalez
• Created: 22/Feb/20 21:29
• Updated: 24/Feb/20 10:53

Description

This is in regard to dependency:  

<dependency>
    <groupId>org.apache.sling</groupId>
    <artifactId>org.apache.sling.testing.sling-mock.junit4</artifactId>
    <!-- Bumping this to 2.4.0 changes behavior in how servlet.service(..) is processed, which breaks all servlet tests -->
    <version>2.3.10</version>
    <scope>test</scope>
</dependency> 

In v2.3.10, in Junit4 tests, invocations of:

ctx.getService(Servlet.class).service(ctx.request(), ctx.response()); 

Worked great, and was a nice way to test a servlet.

When upgrading the dependency to v2.4.0 the tests fail:

java.lang.IllegalArgumentException: Illegal initial capacity: -1java.lang.IllegalArgumentException: Illegal initial capacity: -1
 at java.util.HashMap.<init>(HashMap.java:449) at java.util.HashMap.<init>(HashMap.java:468) at org.apache.sling.models.impl.ExportServlet.createOptionMap(ExportServlet.java:163) at org.apache.sling.models.impl.ExportServlet.doGet(ExportServlet.java:96) at org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266) at org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342) at org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374) at com.adobe.aem.commons.assetshare.content.renditions.impl.AssetRenditionServletTest.doGet_InvalidParameters(AssetRenditionServletTest.java:100) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33) at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230) at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58) 

 

Issue Links

• is cloned by: SLING-9131 OSGi Mock 2.4.14 breaks getting services by highest rank