Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-9030

SimpleDistributionAgentQueueProcessor does not distinguish between recoverable and non-recoverable exceptions

    XMLWordPrintableJSON

    Details

      Description

      SimpleDistributionAgentQueueProcessor.java is responsible for processing a queueItem which is then passed on to RemoteDistributionPackageImporter#importPackage() which in turn selects a valid transporter and send the POST request through SimpleHttpDistributionTransport#deliverPackage(). There can be 2 types of exceptions thrown by this deliverPackage() function. One is a RecoverableDistributionException which is a type of DistributionException and another is DistributionException. As the name suggests, a RecoverableDistributionException is where the transport is tried again. But it seems there is currently no cap on the number of retries.

      For example, if the endpoint is not accessible at the moment, the error logs of the caller application will be flooded with constant retries of the DistributionPackages in queue, until the endpoint comes up and the distribution is successful. The reason being, the verbose logging done here. This would lead to sharp increase in disk size of the caller application. Perhaps the logging can be less verbose and can be logged at WARN level for RecoverableDistributionException.

      cc - Ashish Chopra, Timothee Maret

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                marett Timothee Maret
                Reporter:
                mohiaror Mohit Arora
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 40m
                  1h 40m