[SLING-9026] Reduce unused code and move embedded classes to own package space

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Service User Mapper 1.5.2
• Component/s: Service User Mapper
• Assignee: Carsten Ziegeler
• Reporter: Carsten Ziegeler
• Created: 24/Jan/20 15:55
• Updated: 15/Feb/21 11:02
• Resolved: 24/Jan/20 15:58

Description

We can slightly improve the code of ServiceUserMapperImpl by removing some extra checks:

• by using a constructor we don't need to check whether bundle context is null
• we always have an executor - the boolean flag was only there for testing; we can solve this in the tests

In addition we should move the embedded Felix utils class to a package space of this module