[SLING-8896] The URI Manipulation Filter should not interfere with data-sly-use parameters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Scripting HTL Compiler 1.2.0-1.4.0
• Fix Version/s: Scripting HTL Compiler 1.2.4-1.4.0, HTL Maven Plugin 1.3.4-1.4.0
• Component/s: Scripting
• Assignee: Radu Cotescu
• Reporter: Radu Cotescu
• Created: 06/Dec/19 19:30
• Updated: 18/Dec/19 15:25
• Resolved: 06/Dec/19 19:54

Description

The following HTL construct will result in an error when trying to initialise the passed use object:

<div data-sly-use.pojo="${'org.example.Pojo' @ path='/a/b/c'}"></div>

What will happen currently is that the path option will be interpreted as a URI manipulation indicator, with the construct being equivalent to:

<div data-sly-use.pojo="/a/b/c/org.example.Pojo"></div>

The bug is caused by the fact that the org.apache.sling.scripting.sightly.impl.filter.URIManipulationFilter acts on all contexts, except for data-sly-template and data-sly-call. However, the filter should exclude data-sly-template, data-sly-call, data-sly-use, data-sly-resource (handled in a runtime extension) and data-sly-include (also handled in a runtime extension).

Issue Links

• causes: SLING-8933 The IncludeRuntimeExtension doesn't correctly normalise paths when using the path manipulation options