Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-8802

JcrResourceBundle should not consider dictionaries with a basename, if no basename is provided

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • i18n 2.5.14
    • None
    • i18n
    • None

    Description

      In a situation where 2 dictionaries are available (one with a basename configured, the other without any basename), the JcrResourceBundle will load (and merge) both if no basename is provided (see [1]).

      This breaks applications where basenames are used to separate multiple ResourceBundles from each other, and there are definitely cases where the basename is not provided (and thu assumed as null).

      I would propose to make the behavior consistent and return only dictionaries with no basename configured if basename is null.

      [1] https://github.com/apache/sling-org-apache-sling-i18n/blob/master/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundle.java#L340

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              joerghoh Joerg Hoh
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m