Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-8424

Enhance Request Parameter Handling to Emulate HTML Forms

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Servlet Helpers 1.1.10
    • Fix Version/s: Servlet Helpers 1.2.0
    • Component/s: Testing
    • Labels:
      None

      Description

      Currently, the MockSlingHttpServletRequest class is set up to mock query parameters only.  It assumes that all request parameters are Strings.  It does not track things like contentType of each parameter.

      I've prototyped some changes to the code in order to allow the mocking of HTML form submissions (including file uploads).  I'd like to submit a PR with those changes.

      I'm raising this issue for discussion before generating the PR in case there is any other ongoing work that I'm not aware of or if there are objections to the idea.

      If you want to preview the changes ahead of the PR, they are in a fork of the code available here: https://github.com/rmcdouga/sling-org-apache-sling-servlet-helpers

        Attachments

          Activity

            People

            • Assignee:
              sseifert Stefan Seifert
              Reporter:
              rmcdouga Rob McDougall
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: