[SLING-7538] Request attributes not correctly reset after using data-sly-resource or data-sly-include with requestAttributes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: Scripting HTL Engine 1.0.20
• Component/s: Scripting
• Assignee: Radu Cotescu
• Reporter: Konrad Windszus
• Created: 08/Mar/18 15:35
• Updated: 20/Mar/18 09:27
• Resolved: 20/Mar/18 09:27

Description

The option requestAttributes introduced with SLING-5812 does not correctly reset the request attributes after the request dispatcher returned. The reason for that is that https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/3b50f91c4f600081f0585e50dfb775c4b2856b89/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/ResourceRuntimeExtension.java#L115 does only reset those reset attributes which have been previously attached to the request. In fact also all attributes which have been added initially through the requestAttributes option need to be removed as well. If you add a new request attribute to the request this new request attribute will not be removed and would still be leveraged in a subsequent call to `data-sly-resource` based on the same request (even if that one doesn't even set an option requestAttributes).
The same applies to https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/3b50f91c4f600081f0585e50dfb775c4b2856b89/src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/IncludeRuntimeExtension.java#L73.

Issue Links

• is broken by: SLING-5812 Add option to include attributes in request scope for Sightly data-sly-resource and data-sly-include