[SLING-7507] Tracker open to early which can cause a NPE.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Commons Log 5.1.0
• Fix Version/s: Commons Log 5.1.2
• Component/s: Commons
• Assignee: Karl Pauls
• Reporter: Karl Pauls
• Created: 21/Feb/18 13:07
• Updated: 28/Feb/18 16:55
• Resolved: 21/Feb/18 13:37

Description

The FilterTracker and TurboFilterTracker service tracker are opened in the constructor of the LogbackManager at a time when it isn't fully configured yet. That can lead to an NPE if there is a service found right away.  

Caused by: java.lang.NullPointerException: null
        at org.apache.sling.commons.log.logback.internal.LogbackManager$LoggerStateContext.<init>(LogbackManager.java:733)
        at org.apache.sling.commons.log.logback.internal.LogbackManager.determineLoggerState(LogbackManager.java:663)
        at org.apache.sling.commons.log.logback.internal.FilterTracker.getAppenderMap(FilterTracker.java:173)
        at org.apache.sling.commons.log.logback.internal.FilterTracker.addingService(FilterTracker.java:67)
        at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:941)
        at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:870)
        at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
        at org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
        at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:318)
        at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:261)
        at org.apache.sling.commons.log.logback.internal.FilterTracker.<init>(FilterTracker.java:55)
        at org.apache.sling.commons.log.logback.internal.LogbackManager.<init>(LogbackManager.java:153)
        at org.apache.sling.commons.log.logback.internal.Activator.initializeLogbackManager(Activator.java:75)
        at org.apache.sling.commons.log.logback.internal.Activator.start(Activator.java:55)
        at org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:697)
        at org.apache.felix.framework.Felix.activateBundle(Felix.java:2240)

Issue Links

• links to: GitHub Pull Request #2