[SLING-7334] slingstart-maven-plugin: DependencyLifecycleParticipant must only consider Maven modules leveraging the same version of slingstart-m-p

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Slingstart Maven Plugin 1.7.14
• Fix Version/s: Slingstart Maven Plugin 1.7.16
• Component/s: Maven Plugins and Archetypes
• Assignee: Konrad Windszus
• Reporter: Oliver Lietz
• Created: 26/Dec/17 13:06
• Updated: 15/Jan/18 14:49
• Resolved: 12/Jan/18 12:05

Description

The DependencyLifecycleParticipant is always being active for all module leveraging the plugin (in any version). That might lead to problems, when certain modules rely on a newer version of that extension. This is e.g. the case for Validation Core which breaks aggregator builds after switching from org.apache.sling.testing.paxexam to slingstart-maven-plugin (SLING-7298) for integration tests. This module relies on version 1.7.14 of the slingstart-maven-plugin and breaks with older versions.
The slingstart-maven-plugin itself is not part of aggregator project (MNG-1911) though.

[ERROR] Internal error: java.lang.IllegalArgumentException: Unable to resolve dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.IllegalArgumentException: Unable to resolve dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:122)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356)
Caused by: java.lang.IllegalArgumentException: Unable to resolve dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
    at org.apache.sling.maven.slingstart.PomArtifactVersionResolver.resolve (PomArtifactVersionResolver.java:63)
    at org.apache.sling.provisioning.model.ModelResolveUtility.resolveArtifactVersion (ModelResolveUtility.java:94)
    at org.apache.sling.provisioning.model.EffectiveModelProcessor.processArtifact (EffectiveModelProcessor.java:51)
    at org.apache.sling.provisioning.model.ModelProcessor.process (ModelProcessor.java:62)
    at org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel (ModelUtility.java:155)
    at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies (ModelPreprocessor.java:164)
    at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies (ModelPreprocessor.java:88)
    at org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead (DependencyLifecycleParticipant.java:78)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356)
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException

Issue Links

• blocks: SLING-7331 Set up Maven aggregator project for all regular modules
• is related to: SLING-7298 Validation IT: Use slingstart-maven-plugin in favour of pax-exam
• links to: GitHub Pull Request #3