[SLING-7069] CompositeHealthcheck combines subchecks with AND instead of OR

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Health Check Core 1.2.8
• Fix Version/s: Health Check Core 1.2.10
• Component/s: Health Check
• Assignee: Justin Edelson
• Reporter: Joerg Hoh
• Created: 21/Aug/17 15:29
• Updated: 20/Nov/17 22:28
• Resolved: 22/Aug/17 20:49

Description

I have a CompositeHealthcheck like this

<jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0"
    jcr:primaryType="sling:OsgiConfig"
    hc.name="Health Checks (Runtime)"
    hc.mbean.name="runtime-monitoring"
    filter.tags="[tag1,tag2,tag3]"
    hc.tags="[runtime-monitoring]"
    hc.async.cronExpression="50 0/1 * 1/1 * ? *"/>

whenever I run a healthcheck on the tag "runtime-monitoring" the healthchecks tagged with "tag1", "tag2" and "tage3" should be executed.
But whenever I run the healthceck on "runtime-monitoring", noone is executed at all.

I tracked it down to the fact, that only these healthchecks are executed which have all tags (tag1,tag2 and tag3) configured. Which of course none of my tags are.

21.08.2017 17:06:00.502 *DEBUG* [HealthCheck Health Checks (Runtime)] org.apache.sling.hc.util.HealthCheckFilter OSGi service filter in getTaggedHealthCheckServiceReferences(): (&(objectClass=org.apache.sling.hc.api.HealthCheck)(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3))

It seems to me that instead of the AND it should be an OR:

(&(objectClass=org.apache.sling.hc.api.HealthCheck)(|(hc.tags=tag1)(hc.tags=tag2)(hc.tags=tag3)))

Issue Links

• relates to: SLING-3501 Unexpected behaviour when using multiple tags in the web console to run checks