Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-6658

Register models with their implType implicitly

    Details

      Description

      As discussed in SLING-6652, the implementation of the @Exporter feature introduced a undocumented assumption of the order of the adapterTypes.

      This ticket is about always registering any @Model implicitly with its implType, if not specified explicitly. This will allow the ExportServlet to always use the implType while creating the @Model its going to export.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Buuhuu opened a pull request:

          https://github.com/apache/sling/pull/206

          SLING-6658:

          • always reigster the model with its implType, even not specified as adapter explicitly

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Buuhuu/sling feature/SLING-6658

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/sling/pull/206.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #206


          commit ec8564eaf6cda06e025607f885fe48617b28d8b6
          Author: Dirk Rudolph <dirk.rudolph@netcentric.biz>
          Date: 2017-03-17T07:51:30Z

          SLING-6658:

          • always reigster the model with its implType, even not specified as adapter explicitly

          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Buuhuu opened a pull request: https://github.com/apache/sling/pull/206 SLING-6658 : always reigster the model with its implType, even not specified as adapter explicitly You can merge this pull request into a Git repository by running: $ git pull https://github.com/Buuhuu/sling feature/ SLING-6658 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #206 commit ec8564eaf6cda06e025607f885fe48617b28d8b6 Author: Dirk Rudolph <dirk.rudolph@netcentric.biz> Date: 2017-03-17T07:51:30Z SLING-6658 : always reigster the model with its implType, even not specified as adapter explicitly
          Hide
          justinedelson Justin Edelson added a comment -

          applied patch in r1787379. Thanks!

          I also changed the class passed to adapterImplementations.registerModelToResourceType to be implType rather than getting the value back out of the array.

          Show
          justinedelson Justin Edelson added a comment - applied patch in r1787379. Thanks! I also changed the class passed to adapterImplementations.registerModelToResourceType to be implType rather than getting the value back out of the array.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/sling/pull/206

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/sling/pull/206
          Hide
          diru Dirk Rudolph added a comment -

          Added a patch targeting the models documentation page.

          Show
          diru Dirk Rudolph added a comment - Added a patch targeting the models documentation page.
          Hide
          kwin Konrad Windszus added a comment -

          Applied slightly modified documentation patch in r1788419.

          Show
          kwin Konrad Windszus added a comment - Applied slightly modified documentation patch in r1788419 .
          Hide
          kwin Konrad Windszus added a comment -

          Also adjusted the javadoc of the Model annotation in r1791221.

          Show
          kwin Konrad Windszus added a comment - Also adjusted the javadoc of the Model annotation in r1791221 .

            People

            • Assignee:
              kwin Konrad Windszus
              Reporter:
              diru Dirk Rudolph
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development