Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-6544

slingstart-maven-plugin: keepLaunchpadRunning should be replaced by an option which can be used with start and/or stop

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • Slingstart Maven Plugin 1.7.0
    • Tooling
    • None

    Description

      Right now the parameter keepLaunchpadRunning blocks the start mojo until one of the servers is terminated. It is not that easy to explicitly terminate the server though because Maven does not propagate the Ctrl+C to the server.

      Usually it is much more useful to instead block stopping of the server (i.e. the stop mojo).
      I would propose to deprecate keepLaunchpadRunning and instead introduce the following parameter (which may be used together with start and/or stop):
      blockUntilKeyIsPressed which should leverage the Prompter component (http://stackoverflow.com/a/21977269/5155923) which forces the Mojo to wait until the user entered some value.

      Attachments

        Activity

          People

            kwin Konrad Windszus
            kwin Konrad Windszus
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: