Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: JCR Webdav 2.0.2
    • Fix Version/s: JCR Webdav 2.0.6
    • Component/s: JCR
    • Labels:
      None

      Description

      Reported by Marc Speck in [1]

      When PathInfo is null or "/", a response is already created and it makes no
      sense to call super.service() anymore:

      Index: SimpleWebDavServlet.java
      ===================================================================
      — SimpleWebDavServlet.java (revision 691120)
      +++ SimpleWebDavServlet.java (working copy)
      @@ -85,9 +85,9 @@
      uri += slingRepo.getDefaultWorkspace();
      response.sendRedirect(uri);
      }
      + } else

      { + super.service(request, response); }

      -

      • super.service(request, response);
        }

      // ---------- SCR integration
      ----------------------------------------------

      Regards,
      Marc

      [1] http://markmail.org/message/z3tp43u54a7yqhqn

        Activity

        Gavin made changes -
        Workflow re-open possible,doc-test-required [ 12788836 ] no-reopen-closed,doc-test-required [ 12791373 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12765479 ] re-open possible,doc-test-required [ 12788836 ]
        Gavin made changes -
        Workflow Copy of no-reopen-closed,doc-test-required [ 12763479 ] no-reopen-closed,doc-test-required [ 12765479 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12475802 ] Copy of no-reopen-closed,doc-test-required [ 12763479 ]
        Felix Meschberger made changes -
        Workflow jira [ 12441266 ] no-reopen-closed,doc-test-required [ 12475802 ]
        Felix Meschberger made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Felix Meschberger added a comment -

        Fix confirmed to be ok. Closing

        Show
        Felix Meschberger added a comment - Fix confirmed to be ok. Closing
        Felix Meschberger made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s JCR Webdav 2.0.4 [ 12313396 ]
        Resolution Fixed [ 1 ]
        Hide
        Felix Meschberger added a comment -

        Fixed as proposed in Rev. 691374.

        Awating feedback before closing.

        Show
        Felix Meschberger added a comment - Fixed as proposed in Rev. 691374. Awating feedback before closing.
        Felix Meschberger committed 691374 (1 file)
        Reviews: none

        SLING-639 Don't call the base class service method if a redirect
        or error has already been sent. Thanks Marc Speck for reporting.

        Felix Meschberger created issue -

          People

          • Assignee:
            Felix Meschberger
            Reporter:
            Felix Meschberger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development