[SLING-6185] I18NHttpServletRequest#getLocale should never return null

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: i18n 2.5.4
• Fix Version/s: i18n 2.5.6
• Component/s: i18n
• Flags: Patch
• Assignee: Timothee Maret
• Reporter: Timothee Maret
• Created: 25/Oct/16 09:37
• Updated: 22/Dec/16 08:02
• Resolved: 25/Oct/16 19:04

Description

According to the JEE API, the ServletRequest#getLocale should never return null, the ultimate fallback being the default locale for the server.

However, the Sling wrapper o.a.s.i.i.I18NFilter.I18NHttpServletRequest#getLocale may return null in case:
1. the localeResolver does return empty list (allowed as per API)
2. The bundleProvider#getDefaultLocale returns null (not clear if allowed or not)

With the current Sling code, 2. can occurs at https://github.com/apache/sling/blob/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/I18NFilter.java#L198

[0] https://github.com/apache/sling/blob/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/I18NFilter.java#L280-L283