Sling
  1. Sling
  2. SLING-613

Improve error pages on exceptions

    Details

      Description

      The error pages upon exceptions can be improved (following work on SLING-571) by dumping the request progress tracker on the page. Additionally, the request progress tracker should be filled with more information about the request (filters, request path info, used resource types, first occurrence of script errors).

      1. SLING-613.patch
        12 kB
        Alexander Klimetschek

        Activity

        Alexander Klimetschek created issue -
        Hide
        Alexander Klimetschek added a comment -

        Patch that includes all changed mentioned in the summary.

        To test the error page at work, the most easy thing to do is take a jsp and introduce a compiler error.

        Show
        Alexander Klimetschek added a comment - Patch that includes all changed mentioned in the summary. To test the error page at work, the most easy thing to do is take a jsp and introduce a compiler error.
        Alexander Klimetschek made changes -
        Field Original Value New Value
        Attachment SLING-613.patch [ 12388252 ]
        Felix Meschberger made changes -
        Assignee Felix Meschberger [ fmeschbe ]
        Felix Meschberger made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Felix Meschberger committed 688673 (1 file)
        Felix Meschberger committed 688677 (1 file)
        Reviews: none

        SLING-613 Rethrow exceptions while including a resource as JspTagException

        Felix Meschberger committed 688683 (1 file)
        Hide
        Felix Meschberger added a comment -

        Adding fix versions

        Show
        Felix Meschberger added a comment - Adding fix versions
        Felix Meschberger made changes -
        Fix Version/s Scripting Core 2.0.4 [ 12313366 ]
        Fix Version/s Engine 2.0.4 [ 12313280 ]
        Fix Version/s Scripting JSP-Taglib 2.0.4 [ 12313375 ]
        Fix Version/s  Servlets Resolver 2.0.6 [ 12313376 ]
        Hide
        Felix Meschberger added a comment -

        Thanks for providing this patch. This certainly helps.

        Applied the patch slightly modified (mainly the patches to engine module).

        Please close, if this resolves your issue. Thanks.

        Show
        Felix Meschberger added a comment - Thanks for providing this patch. This certainly helps. Applied the patch slightly modified (mainly the patches to engine module). Please close, if this resolves your issue. Thanks.
        Felix Meschberger made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Alexander Klimetschek added a comment -

        Looks good! Thanks for applying the patch!

        Show
        Alexander Klimetschek added a comment - Looks good! Thanks for applying the patch!
        Alexander Klimetschek made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Felix Meschberger made changes -
        Workflow jira [ 12437423 ] no-reopen-closed,doc-test-required [ 12475206 ]
        Felix Meschberger made changes -
        Component/s Servlets [ 12313028 ]
        Component/s Scripting JSP [ 12311943 ]
        Component/s Servlets Resolver [ 12312086 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12475206 ] Copy of no-reopen-closed,doc-test-required [ 12762931 ]
        Gavin made changes -
        Workflow Copy of no-reopen-closed,doc-test-required [ 12762931 ] no-reopen-closed,doc-test-required [ 12766668 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12766668 ] re-open possible,doc-test-required [ 12788563 ]
        Gavin made changes -
        Workflow re-open possible,doc-test-required [ 12788563 ] no-reopen-closed,doc-test-required [ 12791204 ]

          People

          • Assignee:
            Felix Meschberger
            Reporter:
            Alexander Klimetschek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development