[SLING-6139] Updates to sling:alias property breaks aliases

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Component/s: ResourceResolver
• Assignee: Bertrand Delacretaz
• Reporter: Bertrand Delacretaz
• Created: 12/Oct/16 13:12
• Updated: 13/Oct/16 12:16
• Resolved: 12/Oct/16 13:49

Description

I've found another issue with the MapEntries changes (I assume), see below for the failure scenario. Tentatively assigning to Carsten.

This is breaking the testResolveResourceAliasWithUpdate and testResolveResourceAliasJcrContentWithUpdate tests in the launchpad/testservices ResourceResolverTest - I will commit the below changes in launchpad setup with those tests @Ignored as I need the tests to run with the latest bundles for SLING-5135.

Failure scenario

a) Adding both foo and bar aliases from scratch works

curl -u admin:admin -Ftitle=whatever http://localhost:8080/tmp
curl -u admin:admin -X DELETE http://localhost:8080/tmp
curl -u admin:admin -F"sling:alias=foo" -F"sling:alias=bar" http://localhost:8080/tmp
curl http://localhost:8080/bar.json ; echo
curl http://localhost:8080/foo.json ; echo

b) Adding foo first and then updating to foo and bar breaks both foo and bar aliases

curl -u admin:admin -Ftitle=whatever http://localhost:8080/tmp
curl -u admin:admin -X DELETE http://localhost:8080/tmp
curl -u admin:admin -F"sling:alias=foo" http://localhost:8080/tmp
curl http://localhost:8080/foo.json ; echo

curl -u admin:admin -F"sling:alias=foo" -F"sling:alias=bar" http://localhost:8080/tmp
# getting a 404 for both of these now
curl http://localhost:8080/bar.json ; echo
curl http://localhost:8080/foo.json ; echo

Patch which uses the latest snapshots in launchpad

With this patch the ResourceResolverTest mentioned above fails.

Index: launchpad/builder/src/main/provisioning/oak.txt
===================================================================
--- launchpad/builder/src/main/provisioning/oak.txt	(revision 1764392)
+++ launchpad/builder/src/main/provisioning/oak.txt	(working copy)
@@ -42,7 +42,7 @@
 # start the Oak server instance after all components have been configured
 # and started to avoid restarting that component ( see SLING-4556 )
 [artifacts startLevel=16]
-    org.apache.sling/org.apache.sling.jcr.oak.server/1.1.0
+    org.apache.sling/org.apache.sling.jcr.oak.server/1.1.1-SNAPSHOT
 
 [configurations]
   org.apache.felix.jaas.Configuration.factory-GuestLoginModule
Index: launchpad/builder/src/main/provisioning/sling.txt
===================================================================
--- launchpad/builder/src/main/provisioning/sling.txt	(revision 1764392)
+++ launchpad/builder/src/main/provisioning/sling.txt	(working copy)
@@ -59,7 +59,7 @@
     org.apache.sling/org.apache.sling.installer.console/1.0.1-SNAPSHOT
     org.apache.sling/org.apache.sling.installer.provider.jcr/3.1.19-SNAPSHOT
     org.apache.sling/org.apache.sling.jcr.contentloader/2.1.11-SNAPSHOT
-    org.apache.sling/org.apache.sling.jcr.resource/2.8.0
+    org.apache.sling/org.apache.sling.jcr.resource/2.8.1-SNAPSHOT
     org.apache.sling/org.apache.sling.launchpad.content/2.0.8
     org.apache.sling/org.apache.sling.models.api/1.2.2
     org.apache.sling/org.apache.sling.models.impl/1.2.8
@@ -104,7 +104,7 @@
 [artifacts startLevel=15]
     org.apache.sling/org.apache.sling.jcr.jcr-wrapper/2.0.0
     org.apache.sling/org.apache.sling.jcr.api/2.4.0
-    org.apache.sling/org.apache.sling.jcr.base/2.4.0
+    org.apache.sling/org.apache.sling.jcr.base/2.4.1-SNAPSHOT
     org.apache.sling/org.apache.sling.jcr.registration/1.0.2
     org.apache.jackrabbit/jackrabbit-api/${jackrabbit.version}
     org.apache.jackrabbit/jackrabbit-jcr-commons/${jackrabbit.version}
Index: launchpad/testing/src/main/provisioning/model.txt
===================================================================
--- launchpad/testing/src/main/provisioning/model.txt	(revision 1764392)
+++ launchpad/testing/src/main/provisioning/model.txt	(working copy)
@@ -32,6 +32,9 @@
     # Set the servlet resolver's cache size to zero for testing
     servletresolver.cacheSize=I"0"
 
+  org.apache.sling.jcr.base.internal.LoginAdminWhitelistImpl
+    whitelist.regexp="org.apache.sling.(launchpad|junit).*"
+
 [settings]
   org.apache.sling.commons.log.julenabled=true
   
@@ -41,4 +44,4 @@
  [:repoinit]
 create path /repoinit/provisioningModelTest
 
-create service user provisioningModelUser
\ No newline at end of file
+create service user provisioningModelUser