[SLING-5781] [i18n] generating locale from a string is incorrect

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: i18n 2.4.6
• Fix Version/s: i18n 2.4.8
• Component/s: Extensions
• Assignee: Konrad Windszus
• Reporter: Ankit Agarwal
• Created: 13/Jun/16 11:24
• Updated: 05/Aug/16 08:37
• Resolved: 28/Jun/16 11:52

Description

As per sling document here
https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html

parts of locale string are separated by hyphen ("-") like de-DE-MAC but in JCRResourceBundleProvider while extracting locale from a String we are separating parts with underscore ("_") as done here https://github.com/apache/sling/blob/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L586

Should this be change to separate string on "-" basis ?

Issue Links

• links to: GitHub Pull Request #146