[SLING-5767] Include the Illegal Argument Exception message in the logs

• Type: Improvement
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: Event 3.7.6, Event 4.0.2
• Component/s: Extensions
• Labels: easyfix good-first-issue newbie
• Assignee: Unassigned
• Reporter: PuzanovsP
• Created: 08/Jun/16 13:21
• Updated: 28/Jan/22 09:17

Description

Add message to notify the user why his event is invalid.

File: org/apache/sling/event/impl/jobs/Utility.java:50

• Change code attached.

/**

• Check the job topic.
• @return <code>null</code> if the topic is correct, otherwise an error description is returned
  */
  public static String checkJobTopic(final Object jobTopic) {
  final String message;
  if ( jobTopic != null ) {
  if ( jobTopic instanceof String )
  Unknown macro: { boolean topicIsCorrect = false; String exceptionDetails = EMPTY; try { new Event((String)jobTopic, (Dictionary<String, Object>)null); topicIsCorrect = true; } catch (final IllegalArgumentException iae) { exceptionDetails = iae.getLocalizedMessage(); } if ( !topicIsCorrect ) { message = "Discarding job - job has an illegal job topic, due to: ".concat(exceptionDetails); } else { message = null; } }

  else

  { message = "Discarding job - job topic is not of type string"; }

  } else

  { message = "Discarding job - job topic is missing"; }

  return message;
  }

Issue Links

• links to: GitHub Pull Request #3