[SLING-5664] Models: OSGiServiceInjector does not consider service.ranking

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Sling Models Impl 1.2.6
• Fix Version/s: Sling Models Impl 1.2.8
• Component/s: Extensions
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 15/Apr/16 09:11
• Updated: 09/Sep/16 13:20
• Resolved: 18/Apr/16 16:46

Description

The injector is using BundleContext.getServiceReferences(Class, String) or SlingScriptHelper.getServices(Class, String) (https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java#L97). From the returned array it just takes the first item.
Unfortunately the order in that array is not-deterministic, especially it is not necessarily that way that items with a higher service.ranking are returned first.

Issue Links

• is related to: SLING-5665 SlingScriptHelper.getServices(Class, String) should return the highest matching service ranking first