[SLING-5612] AssertCalendar needlessly compares timezone offsets

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: JCR Resource 2.7.4
• Fix Version/s: JCR Resource 2.8.0
• Component/s: JCR
• Assignee: Bertrand Delacretaz
• Reporter: Bertrand Delacretaz
• Created: 16/Mar/16 07:37
• Updated: 22/Jun/16 13:47
• Resolved: 16/Mar/16 07:41

Description

The AssertCalendar class in the test code compares Calendar objects like this:

assertEquals(expected.getTime(), actual.getTime());
assertEquals(expected.getTimeZone().getRawOffset(), actual.getTimeZone().getRawOffset());

Comparing the timezones is not needed IMO, Calendar internally stores stores the time in msec since the epoch, so comparing getTimeInMillis() is sufficient to declare two Calendars as pointing to the same time. For our tests, it's fine for the timezones to be different.