[SLING-5610] ResourceUtil.getValueMap() contains a wrong @Nonnull annotation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: API 2.9.0
• Fix Version/s: API 2.12.0
• Component/s: API
• Assignee: Konrad Windszus
• Reporter: Dominik Lienemann
• Created: 15/Mar/16 14:59
• Updated: 09/Jul/16 17:01
• Resolved: 15/Mar/16 15:04

Description

org.apache.sling.api.resource.ResourceUtil.getValueMap(res) performs a null check as first action (if ( res == null ) {). Also, the javadoc states that this method is null safe.

But the method contains a @Nonnull annotation for the res parameter (@Nonnull final Resource res) which forces the calling methods to do an additional null check, even if the method handles it internally.

I suggest to remove the annotation for the parameter.