[SLING-5578] Json rendering is using recursion for processing flat trees and causes stack overflows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Commons JSON 2.0.16
• Fix Version/s: Commons JSON 2.0.18
• Component/s: Commons
• Assignee: Bertrand Delacretaz
• Reporter: Marius Petria
• Created: 02/Mar/16 13:08
• Updated: 27/May/16 11:45
• Resolved: 18/May/16 10:38

Description

ResourceTraversor.collectChildren is unnecessarily using recursion and causes stack overflows for flat trees.

Example: for a node with 10k direct children it adds 10k calls on the stack. This should be implemented in an iterative way or at most it should do recursion only for the tree depth.

[1] https://github.com/apache/sling/blob/7c4a53755aed1211c9af313a3973cd2543a7bbe0/bundles/commons/json/src/main/java/org/apache/sling/commons/json/sling/ResourceTraversor.java#L84