[SLING-5448] AuthenticationInfoPostProcessor javadoc misleading

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Auth Core 1.3.12
• Fix Version/s: Auth Core 1.5.0
• Component/s: Authentication
• Assignee: Carsten Ziegeler
• Reporter: Alexander Klimetschek
• Created: 22/Jan/16 00:07
• Updated: 28/Aug/20 12:42
• Resolved: 05/Aug/20 13:29

Description

Currently, the AuthenticationInfoPostProcessor javadoc says:

Service interface which allows bundles to modify the AuthenticationInfo object after authentication has been performed.

But that's pretty misleading, as "after authentication" actually means "one AuthenticationHandler has returned an AuthenticationInfo" object, but does not include the resource provider creations (e.g. JCR repository login), which are often understood as part of authentication too.

I suggest this instead:

Service interface which allows bundles to modify the AuthenticationInfo object right after one authentication handler has returned it from extractCredentials() or for an anonymous AuthenticationInfo. It is called before the resource resolver is created and any authentication in the resource providers (such as JCR repository login) happens.

As such it is useful to intercept responses from other AuthenticationHandlers and access or modify the AuthenticationInfo before they are actually used to create the resource resolver.