[SLING-5315] rescheduled failed jobs increment queued jobs counter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Event 3.7.6
• Fix Version/s: Event 4.0.0
• Component/s: Extensions
• Environment: seen in sling.event 3.7.6
• Assignee: Carsten Ziegeler
• Reporter: Stefan Egli
• Created: 19/Nov/15 13:46
• Updated: 26/Sep/19 12:38
• Resolved: 24/Nov/15 16:40

Description

When a job fails and is rescheduled (eg in 60sec), then the statistics are skewed:

• a job start calls stats.addActive which decrements queuedJobs
• for a failed job, queue.finishJob indirectly calls stats.failedJob which increments queuedJobs again
• then the job is marked for rescheduling in eg 60sec
• then upon rescheduling in queue.requeue, indirectly stats.incQueued is called, which increments queuedJobs as well

With the result that the queuedJobs counter is incremented each time a job fails - even though there are not really more jobs in the queue.