[SLING-4997] Inconsistency in ModelFactory.isModelClass()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Sling Models API 1.2.0
• Fix Version/s: Sling Models API 1.2.2, Sling Models Impl 1.2.2
• Component/s: Extensions
• Assignee: Konrad Windszus
• Reporter: Konrad Windszus
• Created: 03/Sep/15 15:57
• Updated: 21/Sep/15 12:37
• Resolved: 10/Sep/15 08:38

Description

With the changes in SLING-4056 there was a change on a method in the ModelFactory:
public boolean isModelClass(Class<?> modelClass) became
public boolean isModelClass(Object adaptable, Class<?> type)

The adaptable parameter was necessary because of the alternate adapter classes defined in https://sling.apache.org/documentation/bundles/models.html#specifying-an-alternate-adapter-class-since-sling-models-110.

If you now have a Model defined like this

@Model(adaptables = Resource.class)
public class MyModel

a call of ModelFactory.isModelClass(<some SlingHttpServletRequest>, MyModel.class) returns true, although the model class is only defined on the adaptable Resource.

On the other hand if you define a model like this

@Model(adapters=MyModel, adaptables = Resource.class)
public class MyModelImpl implements MyModel

a call of ModelFactory.isModelClass(<some SlingHttpServletRequest>, MyModel.class) returns false.

Issue Links

• is related to: SLING-5013 Sling Models API: Add @ProviderType/@ConsumerType annotations