[SLING-4828] JobManagerImpl job persisting doesn't check the created resource

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: Event 3.6.0
• Component/s: Extensions
• Assignee: Unassigned
• Reporter: Tommaso Teofili
• Created: 22/Jun/15 14:03
• Updated: 26/Nov/15 10:12
• Resolved: 26/Nov/15 09:29

Description

JobManagerImpl#addJob persists the job to be started in writeJob however the result of ResourceHelper.getOrCreateResource is neither checked (!=null) nor used so it can be that the returned Resource is null or corrupted and therefore the job could not be persisted correctly, see https://github.com/apache/sling/blob/trunk/bundles/extensions/event/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L846.
E.g. I've experienced some cases where a binary property of a JCR node ends up being null but that is only noticed when the job is executed, not when it's persisted.

Issue Links

• duplicates: SLING-3432 pseudo network partition causes job deserialization issue in a cluster (when reading while job is being reassigned)