[SLING-4676] Clean up threads or refresh threads when put back into the pool

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Commons Threads 3.2.2
• Component/s: Commons
• Assignee: Julian Sedding
• Reporter: Carsten Ziegeler
• Created: 28/Apr/15 14:56
• Updated: 09/Nov/16 08:06
• Resolved: 26/Nov/15 11:02

Description

A thread from the pool might use thread locals which are - for whatever reason - not cleaned up, when the thread is put back into the pool.
This can lead to memory leaks.
We should protect against this.

Unfortunately there is no official API to clean up thread locals. There are solutions out there using reflection.
Another option is to simply discard the thread object after some time of usage and use a fresh one. This needs to include thread objects staying in the pool for a long time

Issue Links

• breaks: SLING-6261 ThreadExpiringThreadPool is relying on uncaught exceptions to kill threads