[SLING-4568] Performance: MergingResourceProvider.ParentHidingHandler adds about 30pp rendering overhead

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Resource Merger 1.2.8
• Fix Version/s: Resource Merger 1.2.10
• Component/s: ResourceResolver
• Labels: performance
• Assignee: Carsten Ziegeler
• Reporter: Joel Richard
• Created: 02/Apr/15 13:21
• Updated: 21/Jul/15 11:57
• Resolved: 27/Apr/15 11:45

Description

When I was analysing all read properties, I noticed a recurring pattern with sling:hideChildren and jcr:primaryType and that more than 40% of the read properties are sling:hideChildren. I figured out that sling:hideChildren is read for all parents in MergingResourceProvider.ParentHidingHandler and that the requests are processed 30-35pp faster just by commenting out the constructor code.

Apache Benchmark results with normal ParentHidingHandler:

50% 272
66% 276
75% 278
80% 281
90% 289
95% 301
98% 493
99% 497

Results with commented out ParentHidingHandler constructor:

50% 185
66% 188
75% 191
80% 194
90% 202
95% 210
98% 333
99% 338

Issue Links

• is related to: SLING-4653 [Regression] Merging resource provider is traversing parent hierarchie for finding hide properties
• is related to: SLING-4596 Performance: Consider optimizing JcrItemResource#getParent and getChild
• is related to: SLING-4611 Performance: Consider optimizing MergedResource#getParent and getChild