Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-4544

Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Engine 2.4.0
    • Fix Version/s: Engine 2.4.4
    • Component/s: Engine
    • Labels:

      Description

      I am profiling an application where 1-5% of the rendering time is spent in MessageFormat.format for SlingRequestProgressTracker.log (see attached screenshot). Since the advanced capabilities of MessageFormat are not required here, it should be rather easy to implement a utility which supports {x} as well but is much faster.

        Attachments

        1. SLING-4544.patch
          6 kB
          Julian Sedding
        2. Screen Shot 2015-03-25 at 10.42.05.png
          94 kB
          Joel Richard

          Activity

            People

            • Assignee:
              tomek.rekawek Tomek Rękawek
              Reporter:
              joelrich Joel Richard
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: