[SLING-4390] webapp deployment: properties in sling.properties overrule web.xml init parameters

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Launchpad Base 2.5.6
• Fix Version/s: Launchpad Base 2.5.8
• Component/s: Launchpad
• Assignee: Carsten Ziegeler
• Reporter: Joerg Hoh
• Created: 04/Feb/15 09:15
• Updated: 12/Mar/15 11:07
• Resolved: 04/Mar/15 08:02

Description

The documentation [1] explictly states, that any parameter in the web.xml will overwrite the variable with the same in sling.properties.

But looking at the code in Sling.java, I find, that into the init() method the parameters from the web.xml are passed in via the propOverwrite map. This map is first applied, and then the sling.properties (if available) is read and applied.
This violates both the documentation on site [1] and also the javadoc of the class.

The impact can be rather huge, as it isn't possible to update parameters which are stored in the sling.properties already with a new version of the web,xml contained in the WAR file. But we need to update the sling.properties file manually.

[1] http://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html#servlet-parameters

Issue Links

• is duplicated by: SLING-3845 Sling runmode cannot be changed via web.xml after first startup