[SLING-4250] Configuration values should be compared by string comparison

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Installer Configuration Factory 1.0.14
• Fix Version/s: Installer Configuration Factory 1.1.0
• Component/s: Installer
• Assignee: Carsten Ziegeler
• Reporter: Carsten Ziegeler
• Created: 16/Dec/14 09:28
• Updated: 12/Jan/15 12:58
• Resolved: 29/Dec/14 10:25

Description

ConfigUtil.isSameData has some logic which compares two configuration dictionaries:

• if the value from dictionary A is a number, a special handling is done which results in string compare if the value from B is a number as well
• otherwise equals is used

Now, if A contains a string and B contains a number, both representing the same value, the dictionaries are considered to be not the same; the special handling is questionable as it only works in one direction.

I think we can relax this and always do a string compare