[SLING-3547] Default handling for numerical types on Sling Models broken

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Sling Models Implementation 1.0.2, Sling Models Implementation 1.0.4
• Fix Version/s: Sling Models Implementation 1.0.6
• Component/s: Extensions
• Assignee: Justin Edelson
• Reporter: Konrad Windszus
• Created: 08/May/14 11:33
• Updated: 28/Jul/14 07:00
• Resolved: 13/May/14 19:37

Description

Currently all default annotations on numeric types lead to the following warning:
org.apache.sling.models.impl.ModelAdapterFactory Default values for class java.lang.Boolean are not supported and the default is not used.

This is due to the fact that first all types are converted from Primitives to Object Wrapper Classes (in mapPrimitiveClasses). Then the comparison against that type only considers Primitives (in getDefaultValue, except for Strings), which obviously failed, because either those were Object Wrapper Classes right from the beginning, or they were converted to those.

In my regard you should compare the Type against e.g. Integer.class instead of Integer.TYPE (ModelAdapterFactory, line 428ff). Otherwise defaults for numerical types will not work.

Issue Links

• is duplicated by: SLING-3789 Default annotation only works with String