[SLING-3500] Make CompositeHealthCheck use HealthCheckExecutor for parallel execution

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Health Check Core 1.1.0
• Component/s: Health Check
• Assignee: Bertrand Delacretaz
• Reporter: Georg Henzler
• Created: 13/Apr/14 21:52
• Updated: 05/Jun/14 07:05
• Resolved: 05/Jun/14 07:05

Description

As the CompositeHealthCheck is used fairly heavily in the well-known product ([1] & [2]) it would be good to make the parallel execution available for the CompositeHealthCheck as well (this would also be in line with the web console that is already using the HealthCheckExecutor).

The attached patch

• uses the HealthCheckExecutor (shortening the implementation of the CompositeHealthCheck.execute() for quite a bit)
• needs to detect cycles in the configuration in a different way (the ThreadLocal does not work anymore)
• comes with a unit test that tests both the execution and the cycle detection

[1] http://localhost:4502/system/sling/monitoring/mbeans/org/apache/sling/healthcheck/HealthCheck/systemchecks.json
[2] http://localhost:4502/libs/granite/operations/content/hr.html/system/sling/monitoring/mbeans/org/apache/sling/healthcheck/HealthCheck/securitychecks