[SLING-3339] avoid Oak warning about external events

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: JCR Resource 2.3.0
• Component/s: JCR
• Assignee: Justin Edelson
• Reporter: Justin Edelson
• Created: 24/Jan/14 15:42
• Updated: 17/Feb/14 15:48
• Resolved: 24/Jan/14 15:53

Description

When running Sling with Oak, the following warning is raised:

24.01.2014 10:28:44.905 *WARN* [pool-3-thread-1] org.apache.jackrabbit.oak.jcr.observation.ObservationManagerImpl Event listener ///*[11111b] is trying to access user information of event EventImpl{type=1, jcrPath='/OakRepositoryIT1390577324073', userID='admin', identifier='/OakRepositoryIT1390577324073', info={}, date=1390577324092, userData=null, external=false} without checking whether the event is external. java.lang.Exception: The event listener was registered here:
	at org.apache.jackrabbit.commons.observation.ListenerTracker.<init>(ListenerTracker.java:59)
	at org.apache.jackrabbit.oak.jcr.observation.ObservationManagerImpl$1.<init>(ObservationManagerImpl.java:113)
	at org.apache.jackrabbit.oak.jcr.observation.ObservationManagerImpl.addEventListener(ObservationManagerImpl.java:111)
	at org.apache.sling.jcr.resource.internal.JcrResourceListener.<init>(JcrResourceListener.java:119)
	at org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProviderFactory.activate(JcrResourceProviderFactory.java:82)

The reason for which can be found at http://jackrabbit.apache.org/oak/docs/differences.html#Observation

To avoid this warning, isExternal() should be checked before calling getUserID().

Issue Links

• relates to: SLING-2773 NPE in JcrResourceListener on missing user id