[SLING-3175] Make MediaRange parser linient to accept invalid Accept header generated by Oracle JDK HttpUrlConnection

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Servlets Post 2.3.2
• Fix Version/s: Servlets Post 2.3.4
• Component/s: Servlets
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 15/Oct/13 12:34
• Updated: 07/Mar/14 10:39
• Resolved: 12/Nov/13 16:31

Description

While making a call to Sling using Java URLConnection we get following exception [1]. The root cause is due to parsing of invalid Accept header being sent as part of request

Accept: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2

The problem here is that this header is added by JDK itself [0] and at times its not possible to change the request property of URLConnection created by third party library. Would be helpful to make Sling MediaRange parser more linient

[0] http://hg.openjdk.java.net/jdk6/jdk6-gate/jdk/file/tip/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
[1] 15.10.2013 16:51:01.646 WARN [10.40.247.115 [1381836061645] POST /rpc/protocol/model/rf HTTP/1.1] org.apache.sling.servlets.post.impl.helper.MediaRangeList Error registering media type *; q=.2 java.lang.ArrayIndexOutOfBoundsException: 1
at org.apache.sling.servlets.post.impl.helper.MediaRangeList$MediaRange.setType(MediaRangeList.java:237)
at org.apache.sling.servlets.post.impl.helper.MediaRangeList$MediaRange.<init>(MediaRangeList.java:191)
at org.apache.sling.servlets.post.impl.helper.MediaRangeList.init(MediaRangeList.java:90)
at org.apache.sling.servlets.post.impl.helper.MediaRangeList.<init>(MediaRangeList.java:56)
at org.apache.sling.servlets.post.impl.SlingPostServlet.createPostResponse(SlingPostServlet.java:279)
at org.apache.sling.servlets.post.impl.SlingPostServlet.doPost(SlingPostServlet.java:185)