[SLING-3164] Clarify ClusterView.getId (was: Clarify and deprecate ClusterView.getId)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Discovery API 1.0.0
• Fix Version/s: Discovery API 1.0.2
• Assignee: Stefan Egli
• Reporter: Stefan Egli
• Created: 11/Oct/13 15:33
• Updated: 24/Nov/15 09:14
• Resolved: 31/Oct/13 10:36

Description

As discussed on the list (at [0]) the ClusterView.getId() is currently unspecific about whether the id is stable/persistent or not. The current implementation of it is not stable and returns a new id with every changing cluster view. Without assumptions on the underlying implementation details it is not trivial to provide a stable id. This contrasts to the slingId of an InstanceDescription - which is guaranteed to be stable. A cluster can reshape and join another cluster, hence a cluster id is not trivial to be stable.

The suggestion is to clarify the unstable nature of that id in its javadoc and marking it as deprecated - since there is no use for an unstable id really.
–
[0] - http://markmail.org/message/kf3pydso7eruiwfg

Issue Links

• relates to: OAK-3672 discovery-lite should not set (cluster)Id for tarMk and mongoMk (was: SegmentDiscoveryLiteService does not persist clusterView.id)
• relates to: SLING-3195 Provide a property to uniquely identify a Cluster