Sling
  1. Sling
  2. SLING-2947

Merge installer api back into core

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Installer Core 3.4.6
    • Fix Version/s: Installer Core 3.5.0
    • Component/s: Installer
    • Labels:
      None

      Description

      I recently came across a problem when upgrading the installer (core) by itself:

      • the old version is pre 3.4.0 and therefore a single bundle including api
      • the new version is post 3.4.0 where api and core needs to be installed

      The old installer detects that a new core bundle should be installed and runs its update task and updates from 3.3.8 to 3.4.2 - unfortunately at this point, the api bundle is not installed yet and therefore the installer core does not resolve and that's the end of it.

      We'll run into similar problems once we update the API and the core requires the new api.

      So we have two options, add more special casing for handling this situation - or revert SLING-2527 and merge the api back into the core - making it a single unit. I would go the latter way as this is much simpler to handle and avoids adding another special casing which is now even trickier as it requires to check for two bundles - and if they are "compatible" etc.

      I'll go the cleaner road and merge the api back

        Activity

        Hide
        Carsten Ziegeler added a comment -

        Merged api back into core and removed separate api bundle - there is no need to update projects using the api 1.0.0 to depend on the latest core as they depend on specific api packages and their version and not on concrete bundles

        Show
        Carsten Ziegeler added a comment - Merged api back into core and removed separate api bundle - there is no need to update projects using the api 1.0.0 to depend on the latest core as they depend on specific api packages and their version and not on concrete bundles

          People

          • Assignee:
            Carsten Ziegeler
            Reporter:
            Carsten Ziegeler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development