[SLING-2931] Wasted work in SlingServletResolver.activate()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Servlets Resolver 2.3.0
• Component/s: Servlets
• Labels: patch perfomance
• Environment: any
• Assignee: Carsten Ziegeler
• Reporter: Adrian Nistor
• Created: 21/Jun/13 15:54
• Updated: 24/Feb/14 10:19
• Resolved: 04/Jul/13 08:54

Description

The problem appears in version 6 and in revision 1495454. I attached
a one-line patch that fixes it.

In method "SlingServletResolver.activate", the loop over
"executionPaths" should break immediately after "hasRoot" is set to
"true". All the iterations after "hasRoot" is set to "true" do not
perform any useful work, at best they just set "hasRoot" again to
"true".

Method "isLive" in class "ResourceResolverContext" has a similar loop
(over "dynamicProviders"), and this loop breaks immediately after
"result" is set to "false", just like in the proposed patch. Other
methods (e.g., "FactoryPreconditions.checkPreconditions",
"JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
"SecondPassVisitor.appendPageDirective") also have similar loops with
similar breaks, just like in the proposed patch.