Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-2928

Wasted work in LaunchpadConfigInstaller.isActive()

    XMLWordPrintableJSON

    Details

      Description

      The problem appears in revision 1495454. I attached a one-line patch
      that fixes it.

      In method "LaunchpadConfigInstaller.isActive", the loop over
      "runModes" should break immediately after "active" is set to "false".
      All the iterations after "active" is set to "false" do not perform any
      useful work, at best they just set "active" again to "false".

      Method "isLive" in class "ResourceResolverContext" has a similar loop
      (over "dynamicProviders"), and this loop breaks immediately after
      "result" is set to "false", just like in the proposed patch. Other
      methods (e.g., "FactoryPreconditions.checkPreconditions",
      "JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
      "SecondPassVisitor.appendPageDirective") also have similar loops with
      similar breaks, just like in the proposed patch.

        Attachments

        1. patch.diff
          0.6 kB
          Adrian Nistor

          Activity

            People

            • Assignee:
              cziegeler Carsten Ziegeler
              Reporter:
              adriannistor Adrian Nistor
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: