[SLING-2926] Wasted work in AbstractGetAclServlet.doGet()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: JCR Jackrabbit Access Manager 2.1.2
• Component/s: JCR
• Labels: patch perfomance
• Environment: any
• Assignee: Carsten Ziegeler
• Reporter: Adrian Nistor
• Created: 21/Jun/13 15:06
• Updated: 19/Sep/14 15:59
• Resolved: 04/Jul/13 08:37

Description

The problem appears in revision 1495454. I attached a one-line patch
that fixes it.

In method "AbstractGetAclServlet.doGet", the loop over "selectors"
should break immediately after "isTidy" is set to "true". All the
iterations after "isTidy" is set to "true" do not perform any useful
work, at best they just set "isTidy" again to "true".

Method "isLive" in class "ResourceResolverContext" has a similar loop
(over "dynamicProviders"), and this loop breaks immediately after
"result" is set to "false", just like in the proposed patch. Other
methods (e.g., "FactoryPreconditions.checkPreconditions",
"JspUtil.checkAttributes", "EclipseJavaCompiler.compile",
"SecondPassVisitor.appendPageDirective") also have similar loops with
similar breaks, just like in the proposed patch.