[SLING-2920] Wrong handling of Sling Filter ordering

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Engine 2.2.8
• Fix Version/s: Engine 2.3.4
• Component/s: Engine
• Assignee: Carsten Ziegeler
• Reporter: Felix Meschberger
• Created: 18/Jun/13 11:55
• Updated: 24/Dec/15 11:37
• Resolved: 22/May/14 12:52

Description

It looks like the ordering of Sling Filters is not implemented as it is documented on [1].

The documented intent is:

• service.ranking ordering with higher numbers being higher preference over lower numbers
• filter.order ordering with lower numbers being higher preference over higher numbers
• filter.order is ignored if service.ranking is defined
• higher preferenced filters called before lower preferenced filters

Actual implementation:

• service.ranking ordering with lower numbers being higher preference over higher numbers
• filter.order ordering with lower numbers being higher preference over higher numbers
• filter.order is ignored if service.ranking is defined
• higher preferenced filters called before lower preferenced filters

As one can see, the service.ranking ordering is not properly implemented. It looks like this has been wrong since the first implementation as of SLING-1735 (Jan 2011).

We can either live with this actual implementation and fix the documentation or fix the implementation at the cost of having to also fix any down-stream filter providers using service.ranking values as implemented (and not as documented).

Discussion at http://sling.markmail.org/thread/h6uiveb2udw6y46q

[1] http://sling.apache.org/documentation/the-sling-engine/filters.html

Issue Links

• is duplicated by: SLING-2911 Wrong explanation of filter order based on service.ranking