[SLING-2476] Sling installer swallows exceptions for properties config file parsing

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Installer Core 3.3.4
• Fix Version/s: Installer Core 3.3.8
• Component/s: Installer
• Assignee: Carsten Ziegeler
• Reporter: Alexander Klimetschek
• Created: 14/May/12 10:32
• Updated: 07/Feb/17 19:43
• Resolved: 05/Jun/12 17:15

Description

If there is a syntax error in the properties config file (.config), all you get is this:

org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create internal resource (resource will be ignored):InstallableResource, priority=100, id=/libs/sling/config/org.apache.sling.i18n.impl.I18NFilter.config java.io.IOException: Unable to read dictionary from input stream: /libs/sling/config/org.apache.sling.i18n.impl.I18NFilter.config
at org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:99)
at org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:277)
at org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:316)
at org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:579)
at org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:265)

However, debugging shows there is a more specific IOException message available from the dictionary parser:
java.io.IOException: Unexpected token 78; expected: 61 (line=2, pos=4)

InternalResource#readDictionary() is swallowing the IOException in line 250 [0]. It should be added to the exception chain.

[0] http://svn.apache.org/viewvc/sling/trunk/installer/core/src/main/java/org/apache/sling/installer/core/impl/InternalResource.java?revision=1240017&view=markup