Sling
  1. Sling
  2. SLING-2446

Add support for BigDecimal JCR values

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: JCR Resource 2.1.0
    • Component/s: JCR
    • Labels:

      Description

      JCR supports the typehint

      {Decimal}

      for java.math.BigDecimal, but JcrPropertyMap doesn't know about it so doing a map.get(propName, BigDecimal.class) returns null.

      Likewise, you should be able to adapt a Property Resource into a BigDecimal.

        Activity

        Jeff Young created issue -
        Justin Edelson made changes -
        Field Original Value New Value
        Assignee Justin Edelson [ justinedelson ]
        Hide
        Justin Edelson added a comment - - edited

        support added to JcrPropertyMap in r1304366

        Show
        Justin Edelson added a comment - - edited support added to JcrPropertyMap in r1304366
        Justin Edelson made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s JCR Resource 2.1.0 [ 12316202 ]
        Resolution Fixed [ 1 ]
        Hide
        Jeff Young added a comment -

        Hi Justin,

        Just to note that I'm working on a patch; should be uploaded in a few hours.

        Cheers,
        Jeff.

        Show
        Jeff Young added a comment - Hi Justin, Just to note that I'm working on a patch; should be uploaded in a few hours. Cheers, Jeff.
        Hide
        Justin Edelson added a comment -

        resolved prematurely. scope should be broadened.

        Show
        Justin Edelson added a comment - resolved prematurely. scope should be broadened.
        Justin Edelson made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Justin Edelson made changes -
        Summary JCR-1609 added DecimalType, but it didn't get in to Sling's JcrPropertyMap Add support for BigDecimal JCR values
        Description JCR supports the typehint {Decimal} for java.math.BigDecimal, but JcrPropertyMap doesn't know about it so doing a map.get(propName, BigDecimal.class) returns null. JCR supports the typehint {Decimal} for java.math.BigDecimal, but JcrPropertyMap doesn't know about it so doing a map.get(propName, BigDecimal.class) returns null.

        Likewise, you should be able to adapt a Property Resource into a BigDecimal.
        Justin Edelson made changes -
        Issue Type Bug [ 1 ] New Feature [ 2 ]
        Hide
        Justin Edelson added a comment -

        support added to JcrPropertyResource in r1304387

        Show
        Justin Edelson added a comment - support added to JcrPropertyResource in r1304387
        Justin Edelson made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jeff Young added a comment -

        Most of my changes were the same as Justin's, so I just pulled his in. My tests were slightly more complete, however, so I've uploaded a patch containing just my extra tests.

        Show
        Jeff Young added a comment - Most of my changes were the same as Justin's, so I just pulled his in. My tests were slightly more complete, however, so I've uploaded a patch containing just my extra tests.
        Jeff Young made changes -
        Attachment BigDecimal_tests_.patch [ 12519637 ]
        Justin Koke committed 1304461 (1 file)
        Reviews: none

        SLING-2446 - adding more test cases for BigDecimal values (thanks Jeff!)

        Carsten Ziegeler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12659304 ] Copy of no-reopen-closed,doc-test-required [ 12762552 ]
        Gavin made changes -
        Workflow Copy of no-reopen-closed,doc-test-required [ 12762552 ] no-reopen-closed,doc-test-required [ 12765564 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12765564 ] re-open possible,doc-test-required [ 12787462 ]
        Gavin made changes -
        Workflow re-open possible,doc-test-required [ 12787462 ] no-reopen-closed,doc-test-required [ 12790361 ]

          People

          • Assignee:
            Justin Edelson
            Reporter:
            Jeff Young
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development