Sling
  1. Sling
  2. SLING-2445

Deprecate DynamicClassLoaderProvider

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Commons ClassLoader 1.2.4
    • Fix Version/s: Commons ClassLoader 1.3.0
    • Component/s: Commons
    • Labels:
      None

      Description

      The concept of the DynamicClassLoaderProvider - while looking attractive - doesn't work the way it has been intended. The major reason for this interface was dynamic class loading for the scripting support. However we can do this in a much cleaner way through the ClassLoaderWriter (separate issues will follow). A dynamic class loader provider has no way to tell the dynamic class loader manager, that it is not current anymore and a new instance needs to be created. Maybe we could come up with a clever way of doing this, but in the end the effort is not worth it as there is no other usage for this concept than scripting.
      In addition, it opens a door for circumventing the OSGi class loading completely and that's another good reason to forget about this.

      The idea is to:
      a) deprecate the interface
      b) do not call these providers anymore
      c) log a warning if a provider is found

        Activity

        Carsten Ziegeler created issue -
        Hide
        Carsten Ziegeler added a comment -

        Setting this to fixed now after some further testing

        Show
        Carsten Ziegeler added a comment - Setting this to fixed now after some further testing
        Carsten Ziegeler made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Carsten Ziegeler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12659143 ] Copy of no-reopen-closed,doc-test-required [ 12762613 ]
        Gavin made changes -
        Workflow Copy of no-reopen-closed,doc-test-required [ 12762613 ] no-reopen-closed,doc-test-required [ 12766494 ]
        Gavin made changes -
        Workflow no-reopen-closed,doc-test-required [ 12766494 ] re-open possible,doc-test-required [ 12788473 ]
        Gavin made changes -
        Workflow re-open possible,doc-test-required [ 12788473 ] no-reopen-closed,doc-test-required [ 12791161 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        11d 20h 36m 1 Carsten Ziegeler 03/Apr/12 13:26
        Resolved Resolved Closed Closed
        44d 18h 28m 1 Carsten Ziegeler 18/May/12 07:54

          People

          • Assignee:
            Carsten Ziegeler
            Reporter:
            Carsten Ziegeler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development