[SLING-2411] ResourceDecorator(Resource, HttpServletRequest) doesn't get called consistently

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: JCR Resource 2.1.0, API 2.3.0
• Component/s: API, JCR
• Assignee: Justin Edelson
• Reporter: Justin Edelson
• Created: 09/Feb/12 15:11
• Updated: 18/May/12 07:47
• Resolved: 17/Feb/12 00:36

Description

The ResourceDecorator currently has two methods:
decorate(Resource)
decorate(Resource, HttpServletRequest)

The JcrResourceResolver uses the latter method when resolve(HttpServletRequest,String) is invoked. In all other cases, the former method is used. This behavior is correct.

However, the JcrResourceResolver (and any future ResourceResolver implementation for that matter) really doesn't have any control over how it is invoked. For example, at present <sling:include> and <sling:forward> call resolve(String), not resolve(HttpServletRequest,String) (see http://s.apache.org/lL5). But even if we did a code audit within Sling and fixed all the cases like this, we don't have any control over downstream applications which may or may not invoke the two-argument resolve() method.