[SLING-2299] Consolidate constants and utility methods

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Auth Core 1.0.6
• Fix Version/s: Auth Core 1.1.0
• Component/s: Authentication
• Assignee: Felix Meschberger
• Reporter: Felix Meschberger
• Created: 23/Nov/11 15:35
• Updated: 30/Nov/12 17:56
• Resolved: 27/Nov/12 09:35

Description

Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.

We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.

This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.